fix: eth json RPC: eth Filter IDs must act like ints with no leading 0x00 zeros #10261
Conversation
…ization without any leading zeros and include a test
|
This change is causing other tests to fail ie https://app.circleci.com/pipelines/github/filecoin-project/lotus/26527/workflows/d1125d69-1021-46d4-b554-4e6b0d75fe1f/jobs/837726 |
|
@raulk Yeah I think the leading zeros thing can be focused around to just the EthFilterID type - which seems to be generated by a hash, but the jsonrpc is expecting a data format more like an int without leading zeros. There's sort of two heads driving the car (or whatever metaphor makes sense) in the sense that the eth filter json rpc spec seems to imply that there should be no leading zeros but other consumers currently seem to expect it to be more like a hash which allows for leading zeros ie |
|
Should subscriptionID be treated the same way? |
|
Closing this until we have a clear direction / get user feedback on the need. Test being tweaked in #10297 |
Related Issues
#10170
Proposed Changes
change serialization of ethFilterID type to remove leading zeros
Additional Info
itests/eth_conformance_test.go was flaky failing some of the time and this should fix it
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps